Updating events module location for dbt 1.8

dbt-labs / docs.getdbt.com

The code behind docs.getdbt.com

https://docs.getdbt.com/

Apache License 2.0

118 stars 928 forks source link

Updating events module location for dbt 1.8 #5652

Closed pgoslatara closed 2 months ago

pgoslatara commented 3 months ago

What are you changing in this pull request and why?

dbt 1.8 changed the location of the events module from dbt to dbt_common. This PR updates the example accordingly.

Checklist

[x] Review the Content style guide so my content adheres to these guidelines.
[ ] For docs versioning, review how to version a whole page and version a block of content.
[ ] Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding or removing pages (delete if not applicable):

[ ] Add/remove page in website/sidebars.js
[ ] Provide a unique filename for new pages
[ ] Add an entry for deleted pages in website/vercel.json
[ ] Run link testing locally with npm run build to update the links that point to deleted pages

welcome[bot] commented 3 months ago

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨ We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs. We'll review your contribution and respond as soon as we can. 😄

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-getdbt-com	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 9, 2024 5:29pm

nghi-ly commented 3 months ago

heya @dbeatty10, this edit looks correct to me.

before i approve/merge, do we need to use VersionBlock here for the example since it's specific to v1.8 ? i don't see it used on the page at all so i don't think i do but wanted to double-check with you first. thanks!

dbeatty10 commented 3 months ago

before i approve/merge, do we need to use VersionBlock here for the example since it's specific to v1.8 ? i don't see it used on the page at all so i don't think i do but wanted to double-check with you first. thanks!

Good catch @nghi-ly 🦅 -- indeed this does need different VersionBlocks for code this code example prior to v1.8 versus 1.8+.

None of the content on the page was valid until v1.5.

nghi-ly commented 3 months ago

@dbeatty10 : thanks for confirming this! will add versionblock