dbt-labs / docs.getdbt.com

The code behind docs.getdbt.com
https://docs.getdbt.com/
Apache License 2.0
113 stars 861 forks source link

Put the `grant_access_to` limitation behind a version block to avoid confusion #5702

Closed mikealfare closed 5 days ago

mikealfare commented 6 days ago

What are you changing in this pull request and why?

dbt-bigquery has a limitation that affects only versions prior to 1.4. We communicated this by indicating what the issue was for old versions regardless of which version was selected in the version drop down. This created confusion for folks who were looking at a newer version of the docs and still saw the limitation.

Checklist

vercel[bot] commented 6 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 1:33pm
mirnawong1 commented 5 days ago

slack thread: https://dbt-labs.slack.com/archives/C067EUS2D7S/p1719432943863729?thread_ts=1719311116.215959&cid=C067EUS2D7S

mikealfare commented 5 days ago

great solution @mikealfare ! thanks so much and really appreciate this pr! we don't have 1.3 in the docs dropdown since 1.3 is end of life so i wonder if we should just remove the content since it no longer applies for active/supported versions?

Good catch. I've removed the Limitations section entirely since that was the only limitation.