search

dbt-labs / docs.getdbt.com

The code behind docs.getdbt.com
https://docs.getdbt.com/
Apache License 2.0
113 stars 865 forks source link

fix(cumulative metrics): fix some typos #5722

Closed gwenwindflower closed 4 days ago

gwenwindflower commented 5 days ago

Couple quick things I noticed while exploring stuff.

vercel[bot] commented 5 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 0:02am
mirnawong1 commented 4 days ago

hey @gwenwindflower ! thanks for flagging this and opening this pr! I've actually captured the typo in this pr here: https://github.com/dbt-labs/docs.getdbt.com/pull/5688/files#diff-d5effaa3526d0e8fd91e0abfacddbd23acf282f7630b5f0fad324cd2f0ecab9fR19-R36 but am just waiting to confirm when to merge. I've folded in your measure change though !

I'll close this pr up if that's ok with you since it's captured in pr #5688 and it'll help me avoid any merge conflicts 🙏 please let me know if you think otherwise though!

gwenwindflower commented 4 days ago

@mirnawong1 oh nice! yep all good by me!