add ability to add custom schema

dbt-labs / hologram

A library for automatically generating Draft 7 JSON Schemas from Python dataclasses

MIT License

9 stars 13 forks source link

add ability to add custom schema #49

Closed ChenyuLInx closed 2 years ago

ChenyuLInx commented 2 years ago

This PR would allow us to generate custom JSON schema from dataclass TODOs:

[ ] add test

nathaniel-may commented 2 years ago

I haven't worked inside hologram before, so I'd have a lot to catch up on before I could review the impact of this change (even though it's small). I'm going to pull myself off as a reviewer, but I'm happy to talk about it if you'd like.

ChenyuLInx commented 2 years ago

We went with an approach that doesn't require this PR. Closing for now. But if we need this feature we can reopen