Loosen dependency restriction to accept jsonschema 4.0 or better still, remove the upper bound

dbt-labs / hologram

A library for automatically generating Draft 7 JSON Schemas from Python dataclasses

MIT License

9 stars 13 forks source link

Loosen dependency restriction to accept jsonschema 4.0 or better still, remove the upper bound #52

Open groodt opened 1 year ago

groodt commented 1 year ago

There is an upper dependency restriction of jsonschema<4.0.

This makes it more difficult to install dbt into environments with other dependencies installed. jsonschema is a widely used dependency, with notable dependent projects such as jupyterlab and precommit.

Please consider loosening, or removing the upper dependency restriction. This has been requested by others as well previously https://github.com/dbt-labs/hologram/issues/43#issuecomment-1360597485

nehiljain commented 1 year ago

This is causing serious problem in our poetry setup at the moment. What is the priority on this fix?

r-richmond commented 1 year ago

This should be solved once https://github.com/dbt-labs/dbt-core/pull/7221 is merged 🤞

dwreeves commented 1 year ago

@r-richmond Any updates on this? It looks like the PR you linked to was merged.

r-richmond commented 1 year ago

I don't work for DBT but as I understand it the next release of 1.4 and 1.5 will have this fixed.

Personally I forked the 1.3 branch and pulled in that commit and confirm it is working.

dwreeves commented 1 year ago

ah sorry, my mistake. And thank you for the information!