Closed cmcarthur closed 5 years ago
we should probably set additionalProperties: false by default to address this
+1 on this... +1000 really
@beckjake I actually think I should add those back in, because I think I broke all_json_schemas
. what do you think about adding additionalProperties: false
to all of our JSON schemas by default?
@beckjake ready for another look
this doesn't fix the kwargs before positional args problem, but it makes inheritance a little easier. namely:
JsonSchemaMixin.from_dict({...})
that searches the available subclasses for a matchnote that the second breaks everything if you have a JSON schema with additionalProperties: true and all defaults. if you have that registered, every call to
JsonSchemaMixin.from_dict
will return you that thingwe should probably set additionalProperties: false by default to address this