dbt-labs / hubcap

This app adds modules to the hubsite at hub.getdbt.com
13 stars 100 forks source link

Add dbt_tld for maintenance of top level domain lookup table #252

Closed GJMcClintock closed 1 year ago

GJMcClintock commented 1 year ago

Description

This is a simple package that maintains a seed file of the currently accepted IANA TLDs.

Link to your package's repository: https://github.com/GJMcClintock/dbt_tld/tree/0.1.0

Checklist

This checklist is a cut down version of the best practices that we have identified as the package hub has grown. Although meeting these checklist items is not a prerequisite to being added to the Hub, we have found that packages which don't conform provide a worse user experience.

First run experience

Customisability

Dependencies

Dependencies on dbt Core

Versioning

joellabes commented 1 year ago

Hey @GJMcClintock, this is very cool! One comment: instead of calling split_part directly, you should use the cross-db implementation defined here, i.e. {{ dbt.split_part() }}. This will ensure that any warehouses that use a different syntax are also compatible.

That can be handled in a different release though, so I'll merge this!

GJMcClintock commented 1 year ago

@joellabes - I just released a patch to switch to the cord split_part - I didn't realize that was a function. Thanks for the heads up!