search

dbt-labs / hubcap

This app adds modules to the hubsite at hub.getdbt.com
13 stars 100 forks source link

Revert "Rename dbtvault to AutomateDV" #260

Closed dbeatty10 closed 1 year ago

dbeatty10 commented 1 year ago

Reverts dbt-labs/hubcap#258

@DVAlexHiggs If you want to change the name of the package, you'll actually want to change this line.

The line you changed in hub.json is actually the name of the GitHub repo that it will look for.

Here's a good example of a case where the repo name and the package name are different:

Since neither your package name nor GitHub repo changed, I'm going to revert this for now.

Sorry I didn't check this earlier!

DVAlexHiggs commented 1 year ago

@dbeatty10 Hi! Thanks, We already have a PR ready to merge, with the changes you suggested. I wanted to make sure this PR went through first before making the switch.

Would you advise doing it the other way around? (i.e. we change our end first)

dbeatty10 commented 1 year ago

Yep, you should make the changes on your end first, and then we'll make the changes in dbt-labs/hubcap and/or dbt-labs/hub.getdbt.com after that.