search

dbt-labs / hubcap

This app adds modules to the hubsite at hub.getdbt.com
13 stars 100 forks source link

re-add bfdcampos/source_db #289

Closed joellabes closed 1 year ago

joellabes commented 1 year ago

Description

Tell us about your new package!

Link to your package's repository: https://github.com/bfdcampos/source_db

Second attempt at adding package after needing to revert #280 because it seemed to crash hubcap for some reason

joellabes commented 1 year ago

@dbeatty10 Every time I merge this, Hubcap stops running and detecting other package updates, so I have reverted the PR. Any ideas why this might be? It seems to have the expected components in dbt_project.yml etc.

cc @BfdCampos (sorry!)

BfdCampos commented 1 year ago

No worries @joellabes! Having a look as well in case there was something I did wrong but really I can't seem to find anything that's sticking out.

I did find an example package that was added a few months ago that only described the macro-paths. Whereas mine described all the rest test-path, log-path, etc.

That's the only major thing I can think of but please do let me know if there's anything I can do from my side to help 😊

BfdCampos commented 8 months ago

Hi @joellabes @dbeatty10

Been a while but just wanted to check if we have capacity to see if we can merge this package? We're currently building multiple dbt projects for our teams and would be keen to import this as a package rather than a custom individual macro for each project.

Thanks.

dbeatty10 commented 8 months ago

@joellabes I don't know why it is crashing hubcap 😨

I'd suggest running hubcap in a test mode as described here and see if it crashes or not.

joellabes commented 6 months ago

@BfdCampos I worked it out! The 0.1.0 release of the package is incorrectly structured, and hubcap can't find a dbt_project.yml file. I think if you delete that release + tag from GitHub then it should be OK

BfdCampos commented 5 months ago

That's awesome news! I have deleted the 0.1.0 release and tag, the latest release is at 0.1.5. Hubcap should get the latest release right? Or is there anything else I need to do from my side? Would we be able to use the original PR adding source_db to hubcap?

joellabes commented 5 months ago

Hoping that this will work now!