dbt-labs / hubcap

This app adds modules to the hubsite at hub.getdbt.com
13 stars 100 forks source link

Add `dbt-assertions` package to hub #301

Closed AxelThevenot closed 8 months ago

AxelThevenot commented 9 months ago

Description

dbt-assertions is a package designed for data testing capabilities at the row level integrated into the data pipeline flagging each row based on specific assertions it fails.

Link to your package's repository: https://github.com/AxelThevenot/dbt-assertions

Checklist

This checklist is a cut down version of the best practices that we have identified as the package hub has grown. Although meeting these checklist items is not a prerequisite to being added to the Hub, we have found that packages which don't conform provide a worse user experience.

First run experience

Customisability

Dependencies

Dependencies on dbt Core

Versioning

AxelThevenot commented 8 months ago

Update for a generic test and better documentation in 0.1.1 Everything ok now 😇

@joellabes , @dbeatty10

AxelThevenot commented 8 months ago

Oh my bad, let me change this during the day. I though it was a good idea but you're right

Thank you for the feedback I return to you as fast as possible

AxelThevenot commented 8 months ago

What about this image if I keep the for dbt part ? Good for you, @joellabes ? I'll update the documentation according to your answer, thank you 😄

image
joellabes commented 8 months ago

Thanks for the quick turnaround @AxelThevenot! I have checked internally, and the takeaway is that you can't use the logo at all - the relevant part of the trademark guidelines is:

You may use the word Marks, but not the logo Marks, to truthfully describe the relationship between your software or services and ours

However you could do something like this: image

(as long as the word mark includes the ™, which your current version does)

or use the name dbt-assertions on its own because of this carve out:

dbt packages [...] may use the word mark “dbt” as part of the project name

image

Hopefully that makes sense - lmk if not, either here or @joellabes on the community Slack

AxelThevenot commented 8 months ago

Everything is now updated (image and install) Thank you very much for your feedbacks !

joellabes commented 8 months ago

YAY I am so excited to take this for a spin!

AxelThevenot commented 8 months ago

You'll tell me :)

I have an other package I create the PR