search

dbt-labs / hubcap

This app adds modules to the hubsite at hub.getdbt.com
13 stars 100 forks source link

Use the timestamp of the first file within the GZIP archive for `published_at` #322

Closed aranke closed 4 months ago

aranke commented 4 months ago

Description

Use the timestamp of the first file within the GZIP archive for published_at instead of hard-coding to 1970-01-01

Sample PR: https://github.com/dbt-labs/hub.getdbt.com-test/pull/251/files

joellabes commented 4 months ago

This was intentionally removed in https://github.com/dbt-labs/hubcap/pull/141 because it led to a ridiculous number of redundant PRs being opened, what makes you want to bring it back? (Your approach is admittedly much more idempotent than just using the current time).

Not averse to it, but we don't display it anywhere so I'm not sure what filling it out solves.

aranke commented 4 months ago

@joellabes I want to avoid errors like this one: https://github.com/dbt-labs/dbt-core/pull/10260. Currently, each version bump of dbt-utils will break dbt-core because the deps test will break.

Another option if we don't want to go this route is for the Core team to create new packages just for this test that we solely control.

aranke commented 4 months ago

Furthermore, because we're using the idempotent release time, we should not run into merge conflicts like this one: https://github.com/dbt-labs/hub.getdbt.com/issues/1484#issuecomment-1142863530

joellabes commented 4 months ago

We've discussed this separately and are closing for now as we found another way to solve the problem this PR was meant to help with!