feat: dynamic db and schema names - Githubissues

dbt-labs / jaffle-shop-template

Template for a DuckDB-based, Codespace-oriented sandbox project that is also dbt Cloud compatible, and includes code-first BI tooling via Evidence.

51 stars 30 forks source link

feat: dynamic db and schema names #7

Closed aaronsteers closed 1 year ago

aaronsteers commented 1 year ago

This PR introduces 4 environment variables which may be (optionally) used to control the mapping of inputs and outputs.

JAFFLE_DB_PATH - defaults to './reports/jaffle_shop.duckdb' (no change unless overridden)
JAFFLE_DB_NAME - defaults to 'jaffle_shop' (no change unless overridden)
JAFFLE_RAW_SCHEMA - defaults to 'jaffle_raw' (previously 'analytics_raw')
JAFFLE_TARGET_SCHEMA - defaults to 'analytics' (no change unless overridden)

The goal with this PR is to make core input and outputs configurable/swappable, while not breaking existing functionality.

Related

This mirrors a PR against my own fork here (CI tests passed): https://github.com/MeltanoLabs/jaffle-shop-template/pull/2
This simplifies another WIP PR currently targeting my own fork: https://github.com/MeltanoLabs/jaffle-shop-template/pull/1

aaronsteers commented 1 year ago

@gwenwindflower - What do you think of adding the ability to override source and target schema names, as introduced here?

And do you mind approving the CI workflow execution?

I think tests will succeed, but it's always possible I missed something. 😄

gwenwindflower commented 1 year ago

rad @aaronsteers i've got some hours booked tonight to review and get all this in! thank you!