search

dbt-labs / metricflow

MetricFlow allows you to define, build, and maintain metrics in code.
https://docs.getdbt.com/docs/build/about-metricflow
Other
1.12k stars 92 forks source link

Consolidate where constraint predicate pushdown management #1300

Closed tlento closed 2 months ago

tlento commented 2 months ago

Pushdown operations for where constraints were a bit scattered around due to the transition from build-time to optimize-time handling. This consolidates some of the mechanics.

In particular, the where constraint pushdown state updates have been centralized into the PredicatePushdownState object, which allows for more streamlined updates at the callsites, and the where spec propagation has also been simplified to allow for all filter specs to be evaluated at once instead of splitting the evaluation between the WhereConstraintNode and input source node handlers.

github-actions[bot] commented 2 months ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

github-actions[bot] commented 2 months ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

tlento commented 2 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tlento and the rest of your teammates on Graphite Graphite

tlento commented 2 months ago

Merge activity