search

dbt-labs / metricflow

MetricFlow allows you to define, build, and maintain metrics in code.
https://docs.getdbt.com/docs/build/about-metricflow
Other
1.12k stars 92 forks source link

Simplify predicate pushdown state tracking #1301

Closed tlento closed 2 months ago

tlento commented 2 months ago

The original implementation of the state tracker for predicate pushdown was built around an assumption that node-level and node-path access would be useful for propagating the application of filter predicates back up the dependency chain.

After working towards an implementation of that logic it's clear that this is not particularly helpful. Although this tracking is theoretically useful for debugging scenarios the node-visit-level logging appears adequate, so we simplify our tracking before adding additional logic.

github-actions[bot] commented 2 months ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

tlento commented 2 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tlento and the rest of your teammates on Graphite Graphite

tlento commented 2 months ago

Merge activity