Add SQL rendering tests for pushdown edge cases

dbt-labs / metricflow

MetricFlow allows you to define, build, and maintain metrics in code.

https://docs.getdbt.com/docs/build/about-metricflow

Other

1.12k stars 92 forks source link

Add SQL rendering tests for pushdown edge cases #1305

Closed tlento closed 2 months ago

tlento commented 2 months ago

Add SQL rendering tests for pushdown edge cases

The predicate pushdown optimizer tests cover direct edge cases for the optimizer alone, but we would like to have query rendering variations of this so we can see how optimizers interact in their query output.

This adds the relevant query rendering test scenarios along with their associated snapshots.

Update SQL engine snapshots

github-actions[bot] commented 2 months ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

tlento commented 2 months ago

#1308
#1307
#1306
#1305 👈
#1304
#1303
#1302
#1301
#1300
#1286
#1280
#1279
#1278
#1277
#1263
#1262
#1240
#1227
#1230
#1226
#1225
#1224
#1218
#1216 : 1 other dependent PR (#1217 )
#1215
#1214
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tlento and the rest of your teammates on Graphite

tlento commented 2 months ago

Merge activity

Jun 25, 5:24 PM PDT: @tlento started a stack merge that includes this pull request via Graphite.
Jun 25, 5:45 PM PDT: Graphite rebased this pull request as part of a merge.
Jun 25, 5:48 PM PDT: @tlento merged this pull request with Graphite.