dbt-labs / metricflow

MetricFlow allows you to define, build, and maintain metrics in code.

https://docs.getdbt.com/docs/build/about-metricflow

Other

1.12k stars 92 forks source link

fix: Add Column Header to the exported CSV from query command #1313

Closed saurabh0402 closed 1 month ago

saurabh0402 commented 2 months ago

Issue

https://github.com/dbt-labs/metricflow/issues/1285

The CSV exported from the mf query <metric> --csv <csv-file-name> command does not contain the column header. The CSV thus does not make too much sense.

Fix

The code here is writing data to the CSV file. The column names aren't getting added to the file.
With this PR, we are adding the column names returned from df.column_names to the CSV to fix the issue.

saurabh0402 commented 1 month ago

Hey @tlento, thanks for reviewing this. I have added the changelog, please take a look now.

saurabh0402 commented 1 month ago

Hey @tlento, when can we expect this to be released? We just started using metricflow and are facing issues because of this

tlento commented 1 month ago

End of next week, maybe? I need to fix up some deployment issues to allow for a backport and patch release on dbt-metricflow, and that takes some time to test.

saurabh0402 commented 1 month ago

Thanks a lot.

tlento commented 1 month ago

Deployed: https://pypi.org/project/dbt-metricflow/0.7.1/

saurabh0402 commented 1 month ago

Thanks 👍