Rm remaining internal_fixed assets

dbt-labs / snowplow

Data models for snowplow analytics.

https://hub.getdbt.com/dbt-labs/snowplow/latest/

Apache License 2.0

126 stars 45 forks source link

Rm remaining internal_fixed assets #82

Closed jtcohen6 closed 4 years ago

jtcohen6 commented 4 years ago

Resolves #76
In #58, we removed the "internal fixing" that would associate an internally referred session to its parent session. This had the undesirable behavior of breaking relational consistency between events and snowplow_sessions, which ultimately outweighed gains from ease of mapping landing page / UTMs.
This PR removes those macros for good, since they're unused

davehowell commented 4 years ago

@jtcohen6 thank you for clearing that up. Would you mind also updating the image in the README to reflect the change in the models? I still see snowplow_web_events_internal_fixed in there

jtcohen6 commented 4 years ago

@davehowell Good point — I'll include this in the larger suite of updates in #79.