Lift + shift for cross-db macros

dbt-labs / spark-utils

Utility functions for dbt projects running on Spark

https://hub.getdbt.com/fishtown-analytics/spark_utils/latest/

Apache License 2.0

30 stars 15 forks source link

Lift + shift for cross-db macros #25

Closed jtcohen6 closed 2 years ago

jtcohen6 commented 2 years ago

Follow-up to:

https://github.com/dbt-labs/dbt-core/pull/5265
https://github.com/dbt-labs/dbt-utils/pull/594
https://github.com/dbt-labs/dbt-spark/pull/359

jtcohen6 commented 2 years ago

Functional tests are running, which is actually amazing. The other tests are running into a dbt-core error while parsing profiles.yml, which I've just opened as https://github.com/dbt-labs/dbt-core/issues/5268

jtcohen6 commented 2 years ago

The idea would be:

A new minor release, requiring dbt-core v1.2.0, with backwards compatibility for folks calling these macros directly — spark_utils.dateadd. I don't think that's many people, but still!
A subsequent minor release that removes all backwards compatibility