[x] get_url_parameter: This is actually a fix for split_part, which should only add escape characters (\\) if the delimiter needs escaping. Fix: #8
[ ] get_relations_by_prefix_sql, get_tables_by_pattern_sql, get_tables_by_prefix, get_tables_by_pattern: Need rethinking. Spark doesn't have a way of querying an information_schema, only show/describe commands—which do have access to regex-y like but cannot be chained/unioned together. Fix: #10
Integration tests currently failing for macros that otherwise work:
[ ] test_groupby: Star (*) is not allowed in select list when GROUP BY ordinal position is used;
[x] assert_get_query_results_as_dict_objects_equal: The query is not ordered. The way the test is written, if the order in expected_dictionary differs from actual_dictionary, the test fails. Fix: https://github.com/fishtown-analytics/dbt-utils/pull/322
Macros that need reimplementing:
get_url_parameter: This is actually a fix forsplit_part, which should only add escape characters (\\) if the delimiter needs escaping. Fix: #8get_relations_by_prefix_sql,get_tables_by_pattern_sql,get_tables_by_prefix,get_tables_by_pattern: Need rethinking. Spark doesn't have a way of querying aninformation_schema, onlyshow/describecommands—which do have access to regex-ylikebut cannot be chained/unioned together. Fix: #10Integration tests currently failing for macros that otherwise work:
test_groupby:Star (*) is not allowed in select list when GROUP BY ordinal position is used;test_recency: This is a product of how the integration test is currently written, will be fixed by https://github.com/fishtown-analytics/dbt-utils/pull/318test_get_relations_by_pattern: Requires support for schema patterns, whichspark_utils.get_relations_by_patterndoesn't (yet) offertest_equal_column_subset: A minor bug withdbt_utils.equalitywhen used with an ephemeral model + an explicit column subset. Fix: https://github.com/fishtown-analytics/dbt-utils/pull/321assert_get_query_results_as_dict_objects_equal: The query is not ordered. The way the test is written, if the order inexpected_dictionarydiffers fromactual_dictionary, the test fails. Fix: https://github.com/fishtown-analytics/dbt-utils/pull/322