Closed b-per closed 1 year ago
Added some acceptance tests (they ran OK for me) and updated the docs
I am not a huge fan of the fact that if a freshness or docs job is not setup it shows with the id
0 in the state (when it should actually be null) but otherwise it all seems to be working fine!
Hi @GtheSheep ! I am not sure if you saw this PR so this is just a quick ping 😃
hey @b-per! sorry for the slow response, have chucked a couple of comments on here now when you get a chance, thanks again 😸
Thanks for the review 👍 I have added additional context to your comments!
@GtheSheep , no rush, but I'd need you to approve the workflow for this. Let me know if you have any other feedback/question after the ones I posted last time.
@b-per - sorry, forgot about this! will take a look this week and test/ merge
/ok-to-test sha=8e68bcd
Closes #98
This is my attempt at adding links to source freshness and docs jobs (which I called artefacts) at the project level. I also updated the data source to contain the job ids for docs and source freshness.
Behind the scenes, the implementation is quite close to the
project_connection
one, calling thexxxProject()
methods.One thing that I wasn't sure how to manage properly was to get the ids set to
nil
instead of0
when there is nojob_id
defined.This is still WIP but I'd be keen for any feedback until now.
Still to be done: