Fix databricks credentials and update GET endpoint - Githubissues

dbt-labs / terraform-provider-dbtcloud

dbt Cloud Terraform Provider

https://registry.terraform.io/providers/dbt-labs/dbtcloud

MIT License

82 stars 19 forks source link

Fix databricks credentials and update GET endpoint #142

Closed b-per closed 1 year ago

b-per commented 1 year ago

Fix #136 to allow management of Databricks credentials

fixes the issue
update the GET endpoint to check a single credential rather than looping through them
makes the test an acceptance test
update the docs with an updated example

Screenshot with the passing test:

SCR-20230530-rgue

Breaking changes:

fields for the resource have been added and optional/required fields have been changed
- num_threads is removed as it is not relevant for credentials, only for jobs
- added a field for adapter that needs to be set to databricks or spark to handle the different API calls

b-per commented 1 year ago

This PR also contains quite a bit of logic in the difference when creating/modifying credentials whether they are spark or databricks.