feat: License Map Resource

dbt-labs / terraform-provider-dbtcloud

dbt Cloud Terraform Provider

https://registry.terraform.io/providers/dbt-labs/dbtcloud

MIT License

80 stars 18 forks source link

feat: License Map Resource #178

Closed SudoSpartanDan closed 11 months ago

SudoSpartanDan commented 11 months ago

This PR adds the ability to create/manage license maps within DBT Cloud.

SudoSpartanDan commented 11 months ago

I seem to be having issues with the license type already existing in the acceptance test instance. Any possibility to look into the instance to see if a previous test was not cleaned up?

b-per commented 11 months ago

There was one dangling mapping for the Developer license. I just removed it.

SudoSpartanDan commented 11 months ago

There was one dangling mapping for the Developer license. I just removed it.

That did it, this PR is ready for review @b-per

b-per commented 11 months ago

Thanks a lot for getting it passing and for having an Acceptance Test!

I have created #179 to add some minor changes on top of your commits (I don't have access to push to your repo).

As the list of SSO groups is not ordered and should contain unique groups, it is more akin to a set than a list
I have updated the test to check when we are assigning multiple groups

So, when CI passes for #179 I will merge it and close this one

I will update the README and do a new release today as well

SudoSpartanDan commented 11 months ago

Sounds great, thank you!