search

dbt-msft / dbt-sqlserver

dbt adapter for SQL Server and Azure SQL
MIT License
216 stars 101 forks source link

upgrade to support dbt-core v1.5.0 #347

Closed dataders closed 2 months ago

dataders commented 1 year ago

Background

The latest version of dbt Core,dbt-core==1.5.0rc1, was published on April 13, 2023 (PyPI | Github).

How to upgrade

https://github.com/dbt-labs/dbt-core/discussions/7213 is an open discussion with more detailed information. If you have questions, please put them there!

The above linked guide has more information, but below is a high-level checklist of work that would enable a successful 1.5.0 release of your adapter.

the next minor release: 1.6.0

FYI, dbt-core==1.6.0 is expected to be released at the end of July, with a release cut at least two weeks prior.

sdebruyn commented 1 year ago

we should look at #289 now that there is a test for it

romiof commented 1 year ago

I've one question...

With support to dbt 1.5.x, will be possible to create constraints at table / incremental materializations?

sdebruyn commented 1 year ago

@romiof Yes, that should be part of it

virgilp commented 1 year ago

Any idea when dbt-sqlserver will support 1.5 ?

alison985 commented 1 year ago

The following error is also blocking using dbt 1.5.2 and dbt-sqlserver.

ImportError: cannot import name '_make_ref_key_msg' from 'dbt.adapters.cache' (/usr/local/lib/python3.11/site-packages/dbt/adapters/cache.py)

Edit: Add a link to the relevant dbt-core commit.

sdebruyn commented 1 year ago

@virgilp

Any idea when dbt-sqlserver will support 1.5 ?

441 should shed some light on the update

trymzet commented 1 year ago

Bumping, would be great to at least have some clue when it might be coming, since it seems it's pending some major refactoring effort?

If it's going to take another few months, someone in the community might want to pick up and complete https://github.com/dbt-msft/dbt-sqlserver/pull/390 as I think 1.5 has a bunch of new useful features.

DVAlexHiggs commented 1 year ago

Any news on this? We (the AutomateDV dbt package) support SQLServer and are currently unable to upgrade from 1.4, 1.5, 1.6 & 1.7 as we wanted to wait for all adapters to support these new versions. If this isn't releasing any time soon we will need to release without up-to-date support for SQLServer. I understand this is community supported and it takes time - just want to know either way

trymzet commented 10 months ago

For anyone still looking, it looks like 1.7 will be implemented soon, see #461

cody-scott commented 2 months ago

Closing as 1.8 out now