rows_affected in adapter response is 0 for incremental models

dbt-msft / dbt-sqlserver

dbt adapter for SQL Server and Azure SQL

MIT License

216 stars 101 forks source link

rows_affected in adapter response is 0 for incremental models #583

Open unstoppable-allensun opened 4 hours ago

unstoppable-allensun commented 4 hours ago

I seem to be having issues since upgrading to 1.8.4+ of the sql server adapter where the rows_affected is coming back as 0 for incremental models. It used to work in 1.4.3. Is anyone else having this issue or able to reproduce it?

cody-scott commented 2 hours ago

If you pin sql server to 1.8.4 and fabric to 1.8.7 does it work?

unstoppable-allensun commented 2 hours ago

No, that’s what I had originally and then upgraded to 1.8.5 and 1.8.8 of fabric to see if that fixed anything. The issue seems to be happening on the first run when inserting new records into incremental table but when I run again with the same condition it will report correctly.