Update to add parameter to drop-old-relations

dbt-msft / tsql-utils

dbt-utils for the dbt-msft family of packages

MIT License

26 stars 27 forks source link

Update to add parameter to drop-old-relations #107

Open Benjamin-Knight opened 2 weeks ago

Benjamin-Knight commented 2 weeks ago

Add a new parameter to drop old relations macro which works the old way if the parameter is not provided. If provided allows toggling of the logging to the stdout. closes #106

alittlesliceoftom commented 2 weeks ago

Os the pattern of comparing string_variable =='true' the typical way to handle Boolean Args in macros (I don't know but if there was a cleaner way I'd like it). Beyond that lgtm!

Benjamin-Knight commented 2 weeks ago

I was following the previous pattern of the macro which took a boolean flag as a string argument, not sure if there was a reason it was done that way.