Add new macros for sqlserver

dbt-msft / tsql-utils

dbt-utils for the dbt-msft family of packages

MIT License

25 stars 25 forks source link

Add new macros for sqlserver #11

Closed jkock closed 3 years ago

dataders commented 3 years ago

@swanderz any idea why the CI hasn't run on this PR?

there's a setting you have to click for each repo to allow builds to be run on forks. changed it and we're good to go now!

dataders commented 3 years ago

my feeling is to merge these changes in, and slowly chip away at the remaining errors in another PR. I wonder if we can disable some of these models in the interim and add to the README that they aren't yet supported... @jtcohen6 any idea how to do this? perhaps just disable the models?

alittlesliceoftom commented 3 years ago

Agreed, excellent progress, thanks for the contribution and the merge!

On Tue, 22 Dec 2020 at 22:43, Anders notifications@github.com wrote:

Merged #11 https://github.com/dbt-msft/tsql-utils/pull/11 into port_macros.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/dbt-msft/tsql-utils/pull/11#event-4142012658, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVRBJNHOR7UBIANNNZ4CD3SWEOKBANCNFSM4U7H3NYQ .

jtcohen6 commented 3 years ago

yup, just disable the models! exactly as you did in bc6099f (nice anchor)