dbt-msft / tsql-utils

dbt-utils for the dbt-msft family of packages
MIT License
25 stars 25 forks source link

communicte what macros are not supported by tsql-utils #19

Open dataders opened 3 years ago

dataders commented 3 years ago

currently the only place where you can see what models are not supported is by looking at integration_tests/dbt_utils/dbt_project.yml (see below) which is not intuitive, but while the YAML is precise the models and tests in the integration tests don't necessarily correspond 1-1 with individual macros.

Maybe something in the README.md? Or perhaps just one issue per macro? However, dbt_utils.group_by() I know we'll never support. worth mentioning?

currently unsupported

after https://github.com/dbt-msft/tsql-utils/pull/17 the current macros we still could port are: test_split_part() (not working on Synapse?) test_date_spine() insert_by_period materialization generate_series() get_column_values() get_relations_by_pattern() get_relations_by_prefix_and_union() get_url_host() get_url_parameter() get_url_path()

https://github.com/dbt-msft/tsql-utils/blob/b68b3a9d8871fd0963a7f36cf455c29b81be9341/integration_tests/dbt_utils/dbt_project.yml#L22-L62

alittlesliceoftom commented 3 years ago

Above is (I think) the list of macros which are integration tested on dbt_utils, but don't yet work here.

There are also interesting legacy macros that are a bit behind on dbt_utils too, and not fully tested, but represent useful and interesting concepts. For instance - https://github.com/fishtown-analytics/dbt-utils/blob/master/macros/materializations/insert_by_period_materialization.sql the insert by period materialisation here is a useful idea - especially for SQL Server, but doesn't work on a first test in my local and looks like it could generally do with a spruce.

dataders commented 3 years ago

perhaps for all the unsupported macros, we could implement sqlserver__* versions as wrappers for UnsupportedExceptions. @jtcohen6 I remember seeing an example of this somewhere but can't remember now...

jtcohen6 commented 3 years ago

Many of the required adapter macros raise an exception in the default implementation, e.g. list_relations_without_caching.