Closed dataders closed 3 years ago
figured it out! it's because macros needs to be fully qualified inside of a macro, even if they're from the same package, right?
Yes, I think you could be right here:
{% macro synapse__get_url_host(model) %}
{% do return(tsql_utils.sqlserver__get_url_host(model)) %}
{% endmacro %}
@jtcohen6 I'm crossing my fingers that these errors are due to the package inheritance problem that will be ironed out when there's a new release cut...
@swanderz In both CI runs, I'm seeing:
Running with dbt=0.18.1
I think this is because dbt-sqlserver
commented out its dbt-core
dependency (?):
https://github.com/dbt-msft/dbt-sqlserver/blob/ee04bfe8cc899dbec55e9ccb210b24859b5d2bc6/setup.py#L60
Meanwhile, dbt-synapse doesn't pin its dbt-sqlserver dependency, so it installs dbt-core==0.18.1
+ dbt-sqlserver==0.18.1
https://github.com/dbt-msft/dbt-synapse/blob/83a334550e4174d5ed56de4557afcb38f22b16dc/setup.py#L60
In both cases, I'd recommend pinning a dbt version (or upstream dbt adapter version):
dbt-sqlserver v0.19.0-rc1
→ dbt-core v0.19.0-rc1
dbt-synapse v0.19.0-rc1
→ dbt-sqlserver v0.19.0-rc1
And the same when RC2 is released:
dbt-sqlserver v0.19.0-rc2
→ dbt-core v0.19.0-rc2
dbt-synapse v0.19.0-rc2
→ dbt-sqlserver v0.19.0-rc2
UPDATE
figured it out! it's because macros needs to be fully qualified inside of a macro, even if they're from the same package, right?