port necessary macros

[dataders]

goals

the purpose of this PR is to get a baseline set of macros working. there are many still missing, but at least now we have coverage for a few of them. one problem is the way that dbt-utils tests macros is by using schema tests defined within dbt-utils. So next up is to open a PR in dbt-utils to make the schema tests dispatchable.

I'm going to open an example PR shortly that shows how we can incrementally add support for more dbt-utils while also ensuring we're testing that it works.

still to do but now out of scope for this PR

Incorrect syntax near...

• ::
  • [x] cross_db_utils/current_timestamp.sql
  • [x] cross_db_utils/current_timestamp_in_utc.sql
• the keyword with
  • [ ] sql/generate_series.sql
  • [ ] datetime/date_spine.sql
• -
  • [ ] sql/get_relations_by_pattern.sql
  • [ ] sql/get_relations_by_prefix_and_union.sql
• [ ] string_text in cross_db_utils/position.sql

  function is not a recognized built-in function name

• date_trunc
  • [ ] cross_db_utils/date_trunc.sql
  • [ ] cross_db_utils/last_day.sql
• [ ] split_part in cross_db_utils/split_part.sql
• [ ] mod in cross_db_utils/width_bucket.sql
• [x] length in cross_db_utils/length.sql

  MISC

  • Each GROUP BY expression must contain at least one column that is not an outer reference
• [ ] sql/get_column_values.sql
• [ ] sql/groupby.sql
  • Invalid column name 'field'
• [x] cross_db_utils/hash.sql
• [x] sql/surrogate_key.sql

[alittlesliceoftom]

This looks good, but let me test on my local before I approve just so we're 'doing it right'

[dataders]

This looks good, but let me test on my local before I approve just so we're 'doing it right'

1. by turning on CI with #5, we learned of 16 macros that need to be tweaked to work with sql-server (plus an issue with synapse seeds )
2. The milestone for this PR is that we re-implement all the 16 macros I've listed above so that our CI tests pass without issue
3. As an example, I implemented the sqlserver__length() macro, and checked it off. we still have 15 macros left!

[alittlesliceoftom]

Oh, I see!

Sure this was less macros then that but we'll see. Amazing work on the CI!

Tom O'Neill

P.s. We are collecting signatures for fair, independent investigations into Mental Health deaths. Please sign the petition https://petition.parliament.uk/petitions/333684, or find out more at https://www.mentalhealthjustice.uk/ https://www.mentalhealthjustice.uk/

On Mon, 7 Dec 2020 at 12:07, Anders notifications@github.com wrote:

This looks good, but let me test on my local before I approve just so we're 'doing it right'

1. by turning on CI with #5 https://github.com/dbt-msft/tsql-utils/pull/5, we learned of 16 macros that need to be tweaked to work with sql-server (plus an issue with synapse seeds https://github.com/dbt-msft/dbt-synapse/issues/30 )
2. The milestone for this PR is that we re-implement all the 16 macros I've listed above so that our CI tests pass without issue
3. As an example, I implemented the sqlserver__length() macro, and checked it off. we still have 15 macros left!

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/dbt-msft/tsql-utils/pull/6#issuecomment-739877455, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVRBJPQSI534NKWLKPOYL3STTAO5ANCNFSM4UPZSC6A .