Closed dataders closed 3 years ago
This looks good, but let me test on my local before I approve just so we're 'doing it right'
This looks good, but let me test on my local before I approve just so we're 'doing it right'
sqlserver__length()
macro, and checked it off. we still have 15 macros left!Oh, I see!
Sure this was less macros then that but we'll see. Amazing work on the CI!
Tom O'Neill
P.s. We are collecting signatures for fair, independent investigations into Mental Health deaths. Please sign the petition https://petition.parliament.uk/petitions/333684, or find out more at https://www.mentalhealthjustice.uk/ https://www.mentalhealthjustice.uk/
On Mon, 7 Dec 2020 at 12:07, Anders notifications@github.com wrote:
This looks good, but let me test on my local before I approve just so we're 'doing it right'
- by turning on CI with #5 https://github.com/dbt-msft/tsql-utils/pull/5, we learned of 16 macros that need to be tweaked to work with sql-server (plus an issue with synapse seeds https://github.com/dbt-msft/dbt-synapse/issues/30 )
- The milestone for this PR is that we re-implement all the 16 macros I've listed above so that our CI tests pass without issue
- As an example, I implemented the sqlserver__length() macro, and checked it off. we still have 15 macros left!
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/dbt-msft/tsql-utils/pull/6#issuecomment-739877455, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVRBJPQSI534NKWLKPOYL3STTAO5ANCNFSM4UPZSC6A .
goals
the purpose of this PR is to get a baseline set of macros working. there are many still missing, but at least now we have coverage for a few of them. one problem is the way that
dbt-utils
tests macros is by using schema tests defined withindbt-utils
. So next up is to open a PR indbt-utils
to make the schema tests dispatchable.I'm going to open an example PR shortly that shows how we can incrementally add support for more dbt-utils while also ensuring we're testing that it works.
still to do but now out of scope for this PR
Incorrect syntax near...
::
cross_db_utils/current_timestamp.sql
cross_db_utils/current_timestamp_in_utc.sql
with
sql/generate_series.sql
datetime/date_spine.sql
-
sql/get_relations_by_pattern.sql
sql/get_relations_by_prefix_and_union.sql
string_text
incross_db_utils/position.sql
function
is not a recognized built-in function namedate_trunc
cross_db_utils/date_trunc.sql
cross_db_utils/last_day.sql
split_part
incross_db_utils/split_part.sql
mod
incross_db_utils/width_bucket.sql
length
incross_db_utils/length.sql
MISC
sql/get_column_values.sql
sql/groupby.sql
'field'
cross_db_utils/hash.sql
sql/surrogate_key.sql