search

dbtlr / php-airbrake

A PHP 5.3 library for sending errors to the Airbrake.io service.
http://airbrake.io
MIT License
121 stars 44 forks source link

PHP Warning fix + extraParameters from config #33

Closed chenasraf closed 9 years ago

chenasraf commented 9 years ago
  1. Fixed PHP Warning: If we're using Resque - we are almost guaranteed to load it ourselves in order to configure it. Since class_exists() tries to autoload by default, this raises a PHP Warning every time an exception is handled. Setting $autoload=false on the parameter list makes sure it only tests for already existing Resque, not attempt to include it as well.
  2. You can now include 'extraParameters' in your configuration as well and it will be sent to Airbrake's "parameters" field (used to have to be hard coded?)
dbtlr commented 9 years ago

This change may not actually be needed, now that I understand the issue.

There is a new branch in PR #32 which seeks to make this module better tested, and in doing so I removed the Resque integration completely, as I have little proof it is useful to anyone.

If you could perhaps help me out by pulling down the branch from #32 and verifying that it works for your use case, then I could get this merged ASAP.

chenasraf commented 9 years ago

Will do.

chenasraf commented 9 years ago

@dbtlr It works great for me. Go ahead and merge that, I'll open a new PR for the 2nd point in this one and for another thing :)