RoboHome-Web is the codebase that represents the frontend of the RoboHome project. The web interface provides a way to create users, add and manage devices, and an additional way to control devices. :robot: :house_with_garden:
When requesting information about an RF device, the pulse length was omitted. This change will now publish an RF device's pulse length. A corresponding change needs to be made to the RoboHome-ESP8266 repository to read the pulse_length value. This addresses issue #126.
Motivation and Context
If a user had a pulse length for an RF device other than the assumed value of 184 (found in the RoboHome-ESP8266 repository) then the device would not be able to be controlled.
How Has This Been Tested?
Test cases were added to check that the pulse length was published. I also ran Insomnia against the API endpoint info to verify that the pulse length now existed in the JSON response.
Screenshots (if appropriate):
Types of changes
[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Enhancement (non-breaking change which is not noticeable to end users)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
[X] I created a feature branch and did not open a pull request from my master branch.
[X] My code follows the code style of this project.
[ ] My change requires an update to the README and I have updated it accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes.
[X] This is a complete change and doesn't leave the project in a bad state.
Description
When requesting information about an RF device, the pulse length was omitted. This change will now publish an RF device's pulse length. A corresponding change needs to be made to the RoboHome-ESP8266 repository to read the
pulse_lengthvalue. This addresses issue #126.Motivation and Context
If a user had a pulse length for an RF device other than the assumed value of 184 (found in the RoboHome-ESP8266 repository) then the device would not be able to be controlled.
How Has This Been Tested?
Test cases were added to check that the pulse length was published. I also ran Insomnia against the API endpoint
infoto verify that the pulse length now existed in the JSON response.Screenshots (if appropriate):
Types of changes
Checklist:
masterbranch.