RoboHome-Web is the codebase that represents the frontend of the RoboHome project. The web interface provides a way to create users, add and manage devices, and an additional way to control devices. :robot: :house_with_garden:
GNU General Public License v3.0
8
stars
17
forks
source link
Corrected method from POST to GET for MQTT settings #140
Noticed while developing the ESP-8266 that this should be a GET instead of a POST since there is no body of the request and we're only asking for information.
Motivation and Context
Using the correct method is important for readability. Also makes the ESP-8266 code a bit nicer.
How Has This Been Tested?
All unit tests pass.
Screenshots (if appropriate):
Types of changes
[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Enhancement (non-breaking change which is not noticeable to end users)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
[X] I created a feature branch and did not open a pull request from my master branch.
[X] My code follows the code style of this project.
[ ] My change requires an update to the README and I have updated it accordingly.
[ ] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes.
[X] This is a complete change and doesn't leave the project in a bad state.
Description
Noticed while developing the ESP-8266 that this should be a
GETinstead of aPOSTsince there is no body of the request and we're only asking for information.Motivation and Context
Using the correct method is important for readability. Also makes the ESP-8266 code a bit nicer.
How Has This Been Tested?
All unit tests pass.
Screenshots (if appropriate):
Types of changes
Checklist:
masterbranch.