search

dbuenzli / down

An OCaml toplevel (REPL) upgrade
http://erratique.ch/software/down
ISC License
81 stars 3 forks source link

`%%LIBDIR%%` in `down.top` needs to be escaped #38

Open nojb opened 3 months ago

nojb commented 3 months ago

This is because on Windows it is common for %%LIBDIR%% in

https://github.com/dbuenzli/down/blob/e3a4f38e02bf75fd0206d97dc74c6a5c26342023/src/down.top#L9

to contain backslashes, which need to be escaped (eg by using String.escaped) in

https://github.com/dbuenzli/down/blob/e3a4f38e02bf75fd0206d97dc74c6a5c26342023/pkg/pkg.ml#L20

dbuenzli commented 3 months ago

Isn't it rather the #directory directive implementation which should escape ?

Forget about that.