search

dbuenzli / fmt

OCaml Format pretty-printer combinators
http://erratique.ch/software/fmt
ISC License
71 stars 26 forks source link

Use Toploop.load_file for 4.14.0+trunk #50

Closed shakthimaan closed 3 years ago

shakthimaan commented 3 years ago

4.14.0+trunk has deprecated Toploop.use_file and we now need to use Toploop.load_file.

dbuenzli commented 3 years ago

I guess this is issue #49. I'm a bit surprised by this. In the toplevel there is quite a difference between loading a file and using it. Could you please point to the discussion were this happened ?

Also does the fix work in earlier versions ?

shakthimaan commented 3 years ago

I guess this is issue #49.

Yes.

Could you please point to the discussion were this happened ?

I referred the Toploop.mli sources. Source: https://github.com/ocaml/ocaml/blob/a208a29bcc60ff336fc21a96b0a8a128197d5493/toplevel/toploop.mli

Also does the fix work in earlier versions ?

No. This is a breaking change.

dbuenzli commented 3 years ago

I referred the Toploop.mli sources.

Do you actually understand what use_file did and what load_file does ?

No. This is a breaking change.

Well I'm sorry but there's no way I can merge this.

shakthimaan commented 3 years ago

Well I'm sorry but there's no way I can merge this.

Can you please suggest an alternative?

dbuenzli commented 3 years ago

Can you please suggest an alternative?

See the discussion in https://github.com/ocaml/ocaml/issues/10556.

A more general comment, your help is appreciated, but before making PRs, especially a massive amount of them, please make sure you understand what you do and/or coordinate with me.

shakthimaan commented 3 years ago

... and/or coordinate with me.

Since you had mentioned (https://github.com/ocaml-bench/sandmark/issues/250#issuecomment-890582430) that you didn't have the time, I had created the PR for you to take a look when you can actually get to it. But, thanks for the quick and prompt follow-up. Appreciate it!

I shall coordinate with you in future before making PRs. Thanks again!