search

dbuenzli / topkg

The transitory OCaml software packager
http://erratique.ch/software/topkg
ISC License
69 stars 25 forks source link

Set correct exit code #109

Closed emillon closed 7 years ago

emillon commented 7 years ago

The version in master uses Term.exit, which returns 0 for all "Ok" cases.

This causes commands like topkg build to exit with 0 even when ocaml pkg/pkg.ml build fails (they correctly return using Ok 1 which is then ignored).

Thanks!

dbuenzli commented 7 years ago

Thanks. Your patch is in as d8897f98a5c3840f02c5a691611

emillon commented 7 years ago

Thanks!

cfcs commented 6 years ago

Any chance we could have a release with this patch in it? It's very convient to be able to do topkg bu && topkg te as opposed to ocaml pkg/pkg.ml build && topkg test