dbuenzli / topkg

The transitory OCaml software packager
http://erratique.ch/software/topkg
ISC License
69 stars 25 forks source link

Invalid github url when the version contains a `+` #113

Open ghost opened 7 years ago

ghost commented 7 years ago

When I ran topkg opam submit to submit the 1.0+beta9 of jbuilder I got a 404. I had to change the last part of the url generated by topkg opam pkg from jbuilder-1.0+beta9.tbz to jbuilder-1.0.beta9.tbz.

dbuenzli commented 7 years ago

Did you get were this came from ? Is github replacing + with . ? What archive name does topgk distrib generate ?

ghost commented 7 years ago

It seems that github is indeed replacing the + by a .. This is the full URL where the archive in question is available on github: https://github.com/janestreet/jbuilder/releases/download/1.0%2Bbeta9/jbuilder-1.0.beta9.tbz

topkg distrib generates this name: jbuilder-1.0+beta9.tbz.

dbuenzli commented 7 years ago

Annoying.