search

dbuenzli / topkg

The transitory OCaml software packager
http://erratique.ch/software/topkg
ISC License
69 stars 25 forks source link

Topkg.OS.cmd_exists, consider using `which` instead of `type` #99

Closed dbuenzli closed 7 years ago

dbuenzli commented 7 years ago

and add a dependency on conf-which see discussion here.

dbuenzli commented 7 years ago

The rationale for not using type was made here https://github.com/dbuenzli/bos/issues/52

dbuenzli commented 7 years ago

So it doesn't really apply here since we are using Sys.command which goes through a shell. Now before considering changing this I'd really like to understand why @freuk had to peform that terrible dance.

dbuenzli commented 7 years ago

If noone is able to give me an explanation on that one I'm going to close this, I don't see any reason why type shouldn't work here.

dbuenzli commented 7 years ago

Closing this. Feel free to reopen if you are able to provide more information.