dbuenzli / vg

Declarative 2D vector graphics for OCaml
http://erratique.ch/software/vg
ISC License
86 stars 12 forks source link

Cairo 0.6 removes labels #20

Closed Chris00 closed 5 years ago

Chris00 commented 5 years ago

Cairo 0.6 removes many labels ~x, ~y when they are not adding a clear benefit. The rationale is that these labels were added at a time where merlin did not exists and could serve as quick documentation by requesting the signature. Now that dune default mode requires labels, many users will feel compelled to add them... which makes many calls quite heavy. Since Vg uses some of these labels, it needs to be adapted.

dbuenzli commented 5 years ago

Now that dune default mode requires labels, many users will feel compelled to add them...

What does that mean ?

Chris00 commented 5 years ago

On 10 October 2018 at 15:30 GMT, Daniel Bünzli wrote:

Now that dune default mode requires labels, many users will feel compelled to add them...

What does that mean ?

The default flags in Dune require labels to be present.

dbuenzli commented 5 years ago

The default flags in Dune require labels to be present.

Ah didn't know that. What a stupid idea to alter the default flags of the compiler.