Feature/upgrade light functionality

[eerison]

a new parameter was introduced to handle lights

[eerison]

@dbuezas do you know any easy way to test this change with my HA 🤔 ?

[dbuezas]

Hi :wave: yes it is quite easy to test, just copy the files you modified to your home assistant computer, inside config/custom_components/icsee-ptz. Then restart home assistant.

I suggest you try the samba mount add on so you can access the home assistant folders directly from your pc as a network drive.

https://github.com/home-assistant/addons/blob/master/samba/DOCS.md

[eerison]

@dbuezas i guess the code is good to review :)

[dbuezas]

Cool, thanks! Can you readd the deleted one? The cameras are a bit like the wild west, mine worked with the old config

[eerison]

Cool, thanks! Can you readd the deleted one? The cameras are a bit like the wild west, mine worked with the old config

Did you test your camera with this code?

Because I tested a old one and both are working with this code.

Did you updated your app? I don't know, but I guess it comes in a new update.

[eerison]

In theory your camera should work, because it is the new parameter that icsee app is using

[eerison]

I have a camera that work with old config, and this camera worked with this new parameter as well, for this reason I guess it should also work for you

[dbuezas]

As I said, it is the wild west. I don't update cameras anymore because some started using their custom video protocol and go2rtc doesn't work well with it.

[dbuezas]

Lets keep both for a while :)

[eerison]

Lets keep both for a while :)

Should I create a new select for this? Or how can I keep both?

[eerison]

Could you check again @dbuezas please :)

[dbuezas]

I don't have a computer for some weeks but it looks good! Thanks for the contribution!

[eerison]

I don't have a computer for some weeks but it looks good! Thanks for the contribution!

when you have some time could you generate a release or pre-release 👀

[dbuezas]

Done (pre-release)