dbuezas / lgt8fx

Board Package for Logic Green LGT8F328P LGT8F328D and LGT8F88D
362 stars 87 forks source link

lgt8f/variants/standard/pins_arduino.h modified to remove compilation warnings. #122

Closed LaZsolt closed 3 years ago

jayzakk commented 3 years ago

That commit also contains some change to port_to_PCMSK_PGM, where does it relate to?

LaZsolt commented 3 years ago

@jayzakk

That commit also contains some change to port_to_PCMSK_PGM, where does it relate to?

1.) That change correcting a warning, because this line:

const uint8_t PROGMEM port_to_PCMSK_PGM[] = { (uint8_t *)0, (uint8_t *)0, &PCMSK0, &PCMSK1, &PCMSK2, &PCMSK3, &PCMSK4 };

lead to this warning:

.....variants\standard\pins_arduino.h:404:47: warning: initialization makes integer from pointer without a cast [-Wint-conversion]

So I made that missing cast.

2.) The 2nd change is: 328D variant has no IO register PCMSK4. #if defined(__LGT8FX8P__) choose the right macro definition between P and D variant.

jayzakk commented 3 years ago

Thank you!