search

dbuezas / lgt8fx

Board Package for Logic Green LGT8F328P LGT8F328D and LGT8F88D
359 stars 90 forks source link

1.0.7 had changed analogRead functionality which differs from normal! Beware! #232

Closed dwillmore closed 1 year ago

dwillmore commented 1 year ago

1.0.7 was released with a changed default analogRead functionality which differs from earlier 1.0.x versions of the library. Please be aware of this. 1.0.7 is being pulled from distribution. A new 2.0.x branch will be opened as this is an API breaking chagne. Please look for that version shortly. We are pondering a release of a 1.0.8 with the analogRead functionality removed--which will allow people who need the old functionality to use existing code without changes and to benefit from all of the other improvements made since 1.0.6.

Expect more information shortly. Sorry for the confusion.

dbuezas commented 1 year ago

v1.0.7 is now fully deleted, and v2.0.0 is released.

LaZsolt commented 1 year ago

@dwillmore

Do you mean the changed default analog resolution from 12 to 10? For the backward compatibility with the ATmega328P of the default analogReadResolution changed to 10.

dwillmore commented 1 year ago

My understanding is that all releases through 1.0.6 used 12 bits A/D and 1.0.7 moved to the Arduino compatable default of 10 bit A/D. Since this would break existing code expecting to see 0-4094 (?) it was decided to push that change to a 2.0.x release as it's a change in the API.

I'm sure David can provide more details in the morning.

dbuezas commented 1 year ago

Yes, and it was a good change, our only concern is that it will break code made for v1.0.6. By changing the major version, we're signaling breaking changes from the older version :)