dbuezas / lgt8fx

Board Package for Logic Green LGT8F328P LGT8F328D and LGT8F88D
359 stars 90 forks source link

Cleanup boards.txt #266

Closed dbuezas closed 1 year ago

dbuezas commented 1 year ago

The boards.txt file became unnecessarily big. This PR reduces its size from 414 to 87 lines without losing features by:

image image image image

Specifically, it:

dbuezas commented 1 year ago

@seisfeld @wollewald Your feedback is also welcome :) If I didn't miss anything, this would be released as v3.0.0

LaZsolt commented 1 year ago

I'll test the new menu after morning. Does the divider menu look better this way?

1
1/2
1/4
1/8
1/16
1/32
dbuezas commented 1 year ago

It's also an option. We could use:

I just thought that "divider" seems to be what we call it in issues

dbuezas commented 1 year ago

BTW, I tested it with an LQFP48 which has an external 16MHz xtal too, didn't see any issues.

LaZsolt commented 1 year ago

Prescaler.

dbuezas commented 1 year ago

(updated screenshot to Internal 32MHz)

dbuezas commented 1 year ago
image

This is how it looks with fractions

dbuezas commented 1 year ago

IMO the UI is much easier to understand and configure without the extra boards for each crystal. And the boards.txt is also way easier to follow

wollewald commented 1 year ago

Hi I just tried it. Looks better than before. And I would recommend to keep "clock divider" and not multiplier or prescaler. I think it's best understandable for beginners. A pedantic comment: If you choose "Clock divider" and take the fraction style, e. g. 1/32, it's not correct. 32 is the divider and not 1/32. Then multiplier would be correct.

dbuezas commented 1 year ago

Release in progress