search

dbuezas / lovelace-plotly-graph-card

Highly customisable Lovelace card to plot interactive graphs. Brings scrolling, zooming, and much more!
411 stars 20 forks source link

URL duplicated in the `no_default_layout` deprecation message #336

Open ankostis opened 11 months ago

ankostis commented 11 months ago

When using the deprecated no_default_layout (replaced by raw_plotly_config), eg:

type: custom:plotly-graph
no_default_layout: true
...

... the warning message contains 2 links to the docs: image

... but the 2nd link is the same as the 1st one, while it should point to #204 (i guess): https://github.com/dbuezas/lovelace-plotly-graph-card/blob/661dab2f2886565f0e93262d7bc50378595bcf0a/src/parse-config/deprecations.ts#L12

dbuezas commented 11 months ago

Thanks for the issue. It's intentional, the deprecation guide is just to replace it with what is stated in the linked section of the readme:

image

Is there anything missing from that?

ankostis commented 11 months ago

No, it's fine (just surprised the msg has 2 links pointing to the same URL)

dbuezas commented 11 months ago

Oh, I see. I'll remove one of them later then to avoid confusion. Keeping open for now