Remove unused (and deprecated) search controller

dbukowski / DBDebugToolkit

Set of easy to use debugging tools for iOS developers & QA engineers.

MIT License

1.27k stars 114 forks source link

Remove unused (and deprecated) search controller #34

Closed jcavar closed 4 years ago

jcavar commented 4 years ago

Rewire delegate to UISearchBar instance. UISearchController is deprecated and is raising warning when compiling our code. It also breaks Catalyst builds.

strfn commented 4 years ago

In our builds the application always crash when trying to open the network tab, the crash logs points to UIKitCore: UISearchDisplayControllerNoLongerSupported + 248 is this PR fixing also the crash issue ?

AlexisQapa commented 4 years ago

Just upgraded to iOS 13 only build and it crashes on the the network tab too : Terminating app due to uncaught exception 'NSGenericException', reason: 'UISearchDisplayController is no longer supported when linking against this version of iOS. Please migrate your application to UISearchController.'

dominik-hadl commented 4 years ago

Would be great if this could be merged soon, it's a rather simple change and fixes all the warnings and crashes.