Closed Floriferous closed 5 years ago
Hey @Floriferous thanks for the PR. I wonder whether you could simply place the same condition check for the templating package when adding the google-maps.html
.
It works well! However I'm having a hard time testing this with a blaze project (I never built anything with blaze, and never ever use global variables with Meteor).
A simple meteor repo throws saying Uncaught ReferenceError: Template is not defined
, even though I added the templating
package to the app.
I'd hazard a guess that it just needs to be imported in the file that you're referencing it from.
import { Template } from 'meteor/templating';
Admittedly I moved off Blaze before Meteor implemented modules and I found that import in the default app scaffold 😄
Well of course I could just import it, but I was hoping that I just don't understand oldschool meteor magical global variable syntax :)
You'd have to import Templating
just where you need it, but then you have to use require
, and now Meteor complains about require is not defined
, why is this so hard? 🙄
I'll just fork and completely remove blaze I guess, much faster!
Can you share the test app? the changes you made seem like it'd be no problem
It's simply meteor create test-app
, and then I cloned my branch into the packages/
folder.
Anyways, I republished an updated version of this package here: https://github.com/e-Potek/meteor-google-maps
This made me so happy 😀
Closes #157
This PR makes blaze a weak dependency of this package, meaning that if you don't use blaze in your app, it won't pollute your bundle.
I'm struggling with the html template, meteor tells me this:
How can I handle this?