search

dbus-fuzzer / dfuzzer

D-Bus fuzzer
GNU General Public License v3.0
37 stars 10 forks source link

rand: allow generating arbitrary D-Bus signatures #113

Closed mrc0mmand closed 2 years ago

mrc0mmand commented 2 years ago

Let's extend the random signature stuff a bit and allow generating container types as well.

mrc0mmand commented 2 years ago

So, after some testing this appears to be doing the right thing, but I'd like to wait for Coveralls for the code coverage report to make sure all the new code is covered (they seem to be a bit backed up right now, so it might take a while https://status.coveralls.io/).

mrc0mmand commented 2 years ago

Looks like almost everything new is covered, so it should be good to go, @evverx PTAL!

mrc0mmand commented 2 years ago

LGTM. Thanks!

I'll go ahead and merge it to let Coverity analyze it as well. I haven't tested it thoroughly but once it lands my scripts should be able to detect any issues if there are any.

D'oh, I guess I should've waited with the last commit :-)

mrc0mmand commented 2 years ago

Let me drop the last commit, since it needs further work, so the rest can be merged.

evverx commented 2 years ago

FWIW GitHub prevented me from merging this PR because it changed (even without any branch protection rules) so now I'm a bit more confident in GitHub overall :-) I'll wait for Packit to finish and merge it once it's green.

evverx commented 2 years ago

@mrc0mmand on an unrelated note, v2.1 appears to have been released (yay!) but https://github.com/dbus-fuzzer/dfuzzer/blob/master/meson.build#L2 hasn't been changed accordingly so --version still shows 2.0

mrc0mmand commented 2 years ago

@mrc0mmand on an unrelated note, v2.1 appears to have been released (yay!) but https://github.com/dbus-fuzzer/dfuzzer/blob/master/meson.build#L2 hasn't been changed accordingly so --version still shows 2.0

sigh, that's the second time I forgot to update the version :facepalm:

mrc0mmand commented 2 years ago

Fixed in https://github.com/dbus-fuzzer/dfuzzer/commit/a765fece2c09e98fe6e9d26fd17eb455ce2eb542. Thanks for catching this, hopefully I won't forget to do it next time :-)