search

dbus2 / busd

A D-Bus bus (broker) implementation based on zbus
Other
93 stars 12 forks source link

WIP: Update to zbus git #142

Closed elmarco closed 1 month ago

elmarco commented 1 month ago

There is an issue with a non-Send future..

zeenix commented 1 month ago

There is an issue with a non-Send future..

Fixed your regression for you: https://github.com/dbus2/zbus/pull/1036 :)

elmarco commented 1 month ago

There is an issue with a non-Send future..

Fixed your regression for you: dbus2/zbus#1036 :)

weird stuff... why does it need to be declared Send+Sync+'static?? why isn't it infered like the rest ...

zeenix commented 1 month ago

There is an issue with a non-Send future..

Fixed your regression for you: dbus2/zbus#1036 :)

weird stuff... why does it need to be declared Send+Sync+'static?? why isn't it infered like the rest ...

Because you're the one declaring the type explicitly and therefore get to decided the guarantees. I know it's painful and annoying..

zeenix commented 1 month ago

I rebased this branch on main here. It builds but all the tests fail/hang. I haven't investigated what the issue is but pretty sure it's some minor thing in either the branch or regression in zbus.

zeenix commented 1 month ago

I rebased this branch on main here. It builds but all the tests fail/hang. I haven't investigated what the issue is but pretty sure it's some minor thing in either the branch or regression in zbus.

I investigated this and it is indeed a regression in zbus main. https://github.com/dbus2/zbus/issues/1055.

zeenix commented 1 month ago

I rebased this branch on main here. It builds but all the tests fail/hang. I haven't investigated what the issue is but pretty sure it's some minor thing in either the branch or regression in zbus.

I investigated this and it is indeed a regression in zbus main. dbus2/zbus#1055.

This has been fixed in zbus git main, and my branch passes the tests. However, I have not addressed the review comments here, just made it build and pass the CI locally. I'd suggest resetting this branch to mine before addressing the review comments.

zeenix commented 1 month ago

Closing in favor of #151.