dbus2 / zbus-old

Rust D-Bus crate.
https://gitlab.freedesktop.org/dbus/zbus
Other
49 stars 13 forks source link

Upgrade nix #222

Closed zeenix closed 1 year ago

zeenix commented 2 years ago

In GitLab by @DmitrySamoylov on Oct 8, 2021, 18:47

Hey! cargo deny complains on this exact version of nix:

error[A001]: Out-of-bounds write in nix::unistd::getgrouplist
...
    = ID: RUSTSEC-2021-0119
    = Advisory: https://rustsec.org/advisories/RUSTSEC-2021-0119
    = On certain platforms, if a user has more than 16 groups, the
      `nix::unistd::getgrouplist` function will call the libc `getgrouplist`
      function with a length parameter greater than the size of the buffer it
      provides, resulting in an out-of-bounds write and memory corruption.

      The libc `getgrouplist` function takes an in/out parameter `ngroups`
      specifying the size of the group buffer. When the buffer is too small to
      hold all of the reqested user's group memberships, some libc
      implementations, including glibc and Solaris libc, will modify `ngroups`
      to indicate the actual number of groups for the user, in addition to
      returning an error. The version of `nix::unistd::getgrouplist` in nix
      0.16.0 and up will resize the buffer to twice its size, but will not
      read or modify the `ngroups` variable. Thus, if the user has more than
      twice as many groups as the initial buffer size of 8, the next call to
      `getgrouplist` will then write past the end of the buffer.

      The issue would require editing /etc/groups to exploit, which is usually
      only editable by the root user.
    = Announcement: https://github.com/nix-rust/nix/issues/1541
    = Solution: Upgrade to >=0.20.2, <0.21.0 OR >=0.21.2, <0.22.0 OR >=0.22.2, <0.23.0 OR >=0.23.0
    = nix v0.21.0
      └── zbus v2.0.0-beta.7
zeenix commented 2 years ago

@DmitrySamoylov Hey! Long time no see. :smile_cat: Thanks for reporting! Merge request missing. :laughing: No worries, this is easy to fix..

zeenix commented 2 years ago

In GitLab by @aDotInTheVoid on Oct 9, 2021, 15:05

mentioned in commit aDotInTheVoid/zbus@933b99087ce0efccd7b7c92b6da146f932021494

zeenix commented 2 years ago

mentioned in commit 8fa7bc70788308228e706d80b219d047f028e502