search

dbus2 / zbus-old

Rust D-Bus crate.
https://gitlab.freedesktop.org/dbus/zbus
Other
49 stars 13 forks source link

Feature: Support NO_AUTO_START and ALLOW_INTERACTIVE_AUTHORIZATION in dbus_proxy generated impls #280

Closed zeenix closed 1 year ago

zeenix commented 2 years ago

In GitLab by @benferse on Jul 15, 2022, 20:37

Building on the previous work to support the no_reply attribute in dbus_proxy traits, I'd like to also be able to indicate that one or more of the other header flags should be included when building the messages in the generated code.

If my reading of the spec is correct, it doesn't look there is any need for additional handling of the request/reply messages; simply flipping the right bits in the header should be enough for both NO_AUTO_START and ALLOW_INTERACTIVE_AUTHORIZATION.

A WIP branch with a potential solution is here

zeenix commented 2 years ago

If my reading of the spec is correct, it doesn't look there is any need for additional handling of the request/reply messages; simply flipping the right bits in the header should be enough for both NO_AUTO_START and ALLOW_INTERACTIVE_AUTHORIZATION.

Yeah. Just need to add 2 attributes to the dbus_proxy methods that use the existing API to set the flags on the message.

A WIP branch with a potential solution is here

It's a 404. Could you please submit a merge-request?

zeenix commented 2 years ago

In GitLab by @benferse on Jul 18, 2022, 22:26

Will do as soon as I can merge upstream and fix Windows runs

zeenix commented 2 years ago

Will do as soon as I can merge upstream and fix Windows runs

Cool, windows CI has been fixed in main branch/repo btw so please rebase before you try anything else.

zeenix commented 1 year ago

@benferse pro-tip: If you write Fixes #270. in the MR, the related issue is automatically closed. :)