search

dbus2 / zbus-old

Rust D-Bus crate.
https://gitlab.freedesktop.org/dbus/zbus
Other
49 stars 13 forks source link

Empty signals does not implement `Deref`, `AsRef`, etc. #290

Closed zeenix closed 1 year ago

zeenix commented 1 year ago

In GitLab by @Alxandr on Oct 5, 2022, 23:01

The implementation of Deref and AsRef etc. for signals is behind a branch that checks if the signal is empty. Proxy.rs line 762. I'm looking at the code for another reason, mostly just trying to understand it currently, but I'm guessing this is an oversight? I tried to create a simple proxy with an empty signal just to test, and indeed it does not implement the normal traits. I can create a PR for this is wanted :smile:.

zeenix commented 1 year ago

Thanks so much for filing this. I've not looked at the code but this does sound like an oversight.

All contributions are always welcome! ☺️

zeenix commented 1 year ago

mentioned in commit b0e42889be42f48eb077b7e0e292a51c77202435